Forums » Bugs
Sell/Sell All/Unload Bugs
Bug Type:
Non-Critical
Description:
The Sell/Sell All/Unload/Unload All buttons don't seem to be disabled fast enough which allows you to attempt to sell/unload multiple times. The game mechanics only sell/unload the items once though, however when selling you'll get an extra message stating otherwise as well as an error. I assume the same problem might plague other buttons but I guess it could be a design decision to possibly increase client/server speed or there might simply be a small wait time for the button to be "Validated" and disabled. And just to make it clear, you can't make more money from selling or duplicate items from unloading with this bug.
Example for Sell All:
First Click: 140x of Cargo sold for a total amount of 560c (loss of 140c)
Second Click: 140x of Cargo sold for a total amount of 560c (loss of 140c)
Third Click (after I press a third time, the button is disabled): station error: Unable to find addon.
Reproduction(Sell):
Place items in your active ships cargo hold. Go to the Welcome screen and click on an item and continually press the "Sell" button. When the last time is sold and you quickly press the Sell button once more, you will get an error message stating that the add-ons could not be found.
Reproduction(Sell All):
Place items in your active ships cargo hold and spam press the Sell All button. You should get 2 messages saying what was sold and for how much as well as an error message stating that the add-ons could not be found.
Reproduction(Unload/Unload All):
Follow the reproduction steps for the Sell and Sell All but replace it with the Unload/Unload All button respectfully. You should get an error message stating that the add-ons could not be found.
Non-Critical
Description:
The Sell/Sell All/Unload/Unload All buttons don't seem to be disabled fast enough which allows you to attempt to sell/unload multiple times. The game mechanics only sell/unload the items once though, however when selling you'll get an extra message stating otherwise as well as an error. I assume the same problem might plague other buttons but I guess it could be a design decision to possibly increase client/server speed or there might simply be a small wait time for the button to be "Validated" and disabled. And just to make it clear, you can't make more money from selling or duplicate items from unloading with this bug.
Example for Sell All:
First Click: 140x of Cargo sold for a total amount of 560c (loss of 140c)
Second Click: 140x of Cargo sold for a total amount of 560c (loss of 140c)
Third Click (after I press a third time, the button is disabled): station error: Unable to find addon.
Reproduction(Sell):
Place items in your active ships cargo hold. Go to the Welcome screen and click on an item and continually press the "Sell" button. When the last time is sold and you quickly press the Sell button once more, you will get an error message stating that the add-ons could not be found.
Reproduction(Sell All):
Place items in your active ships cargo hold and spam press the Sell All button. You should get 2 messages saying what was sold and for how much as well as an error message stating that the add-ons could not be found.
Reproduction(Unload/Unload All):
Follow the reproduction steps for the Sell and Sell All but replace it with the Unload/Unload All button respectfully. You should get an error message stating that the add-ons could not be found.
sounds like its just delay between client and server..
Yeah, that's a problem like what PaKettle said. Some of the buttons are disabled during the transaction, but not all of them. One question is should all buttons be disabled or only the one that was pressed?
I think all the buttons that directly influence the cargo should be disabled. If you only disabled the button you pressed, it would eliminate the bug for that button but if you were to start spamming the other buttons you'd still get at least one error.
It really isn't that big of a deal, but I think it would make the interface feel more complete, especially from the stand point of a new player coming in for the first time.
It really isn't that big of a deal, but I think it would make the interface feel more complete, especially from the stand point of a new player coming in for the first time.
Ok, I have edited the code a little so that it shouldn't erroneously show a successful message if there's an error. I started to do the whole greying out of buttons, but if something goes wrong, it's better to error on the side of making the button clickable instead of unclickable.